linux-kernel - Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130620083327.GA5288@gmail.com>
Date:	Thu, 20 Jun 2013 10:33:28 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jed Davis <jld@...illa.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Will Deacon <will.deacon@....com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.


* Jed Davis <jld@...illa.com> wrote:

> With this change, we no longer lose the innermost entry in the user-mode
> part of the call chain.  See also the x86 port, which includes the ip,
> and the corresponding change in arch/arm.
> 
> Signed-off-by: Jed Davis <jld@...illa.com>
> ---
>  arch/arm64/kernel/perf_event.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1e49e5eb..9ba33c4 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
>  		return;
>  	}
>  
> +	perf_callchain_store(entry, regs->pc);
>  	tail = (struct frame_tail __user *)regs->regs[29];
>  
>  	while (entry->nr < PERF_MAX_STACK_DEPTH &&

Acked-by: Ingo Molnar <mingo@...nel.org>

I suspect this goes to v3.10 via the ARM64 tree?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/