linux-kernel - Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Jun 2013 19:20:23 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	"broonie@...nel.org" <broonie@...nel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"rob@...dley.net" <rob@...dley.net>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	Stephen Warren <swarren@...dia.com>,
	"gg@...mlogic.co.uk" <gg@...mlogic.co.uk>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"ian@...mlogic.co.uk" <ian@...mlogic.co.uk>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

Hi,

On Thursday 20 June 2013 04:22 PM, Laxman Dewangan wrote:
> On Thursday 20 June 2013 02:07 PM, Kishon Vijay Abraham I wrote:
>> SMPS10 has two outputs OUT1 and OUT2 and have one input IN1.
>> SMPS10-OUT2 is connected to SMPS10-IN1 and can be configured either
>> in BOOST mode or BYPASS mode. regulator_enable of SMPS10-OUT2 configures
>> it in BOOST mode. For BYPASS mode regulator_allow_bypass() API can be
>> used. SMPS10-OUT1 is connected to SMPS10-OUT2 and can be enabled using
>> regulator_enable().
>>
>> Cc: Laxman Dewangan <ldewangan@...dia.com>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>> ---
>>   drivers/regulator/palmas-regulator.c |   39 ++++++++++++++++++++++++++++++----
>>   include/linux/mfd/palmas.h           |    9 ++++----
>>   2 files changed, 40 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/regulator/palmas-regulator.c
>> b/drivers/regulator/palmas-regulator.c
>> index 3ae44ac..7004bab 100644
>> --- a/drivers/regulator/palmas-regulator.c
>> +++ b/drivers/regulator/palmas-regulator.c
>> @@ -97,7 +97,12 @@ static const struct regs_info palmas_regs_info[] = {
>>           .ctrl_addr    = PALMAS_SMPS9_CTRL,
>>       },
>>       {
>> -        .name        = "SMPS10",
>> +        .name        = "SMPS10_OUT1",
>> +        .sname        = "smps10-out2",
>> +        .ctrl_addr    = PALMAS_SMPS10_CTRL,
>> +    },
>> +    {
>> +        .name        = "SMPS10_OUT2",
>>           .sname        = "smps10-in",
>>
>
> This sequence can create regulator to be never register.
> In probe, we register regulator from 0 to max_id.
> Here smps10-out1 comes first and see the supply as smps10-out2 which is not
> registered yet and so will fail with PROBE_DEFER
> When again it tries, the same issue.

hmm.. But I was able to get (regulator_get) *SMPS10_OUT1* without any issue
during my testing. From looking at the code, I couldn't see *sname* being used
anywhere.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/