linux-kernel - Re: [PATCH] regulator: max77693: Add max77693 regualtor driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130621151930.GB27646@sirena.org.uk>
Date:	Fri, 21 Jun 2013 16:19:30 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jonghwa Lee <jonghwa3.lee@...sung.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, Myungjoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH] regulator: max77693: Add max77693 regualtor driver.

On Thu, Jun 20, 2013 at 04:03:26PM +0900, Jonghwa Lee wrote:
> This patch adds new regulator driver to support max77693 chip's regulators.
> max77693 has two linear voltage regulators and one current regulator which
> can be controlled through I2C bus. This driver also supports device tree.

This is fine but doesn't have a binding document which is needed for new
DT bindings.

A comment in the is_enabled() function explaining that more than one bit
might be set (or replacing it with the generic function) would also be
good.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)