linux-kernel - Re: [PATCH] audit: Fix decimal constant description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWnA0LiLc+aYhZyHGpykFc_Xb0j2MWSPKLKQKaH910pcA@mail.gmail.com>
Date:	Mon, 24 Jun 2013 11:03:51 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Michal Simek <monstr@...str.eu>
Cc:	Michal Simek <michal.simek@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Eric Paris <eparis@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] audit: Fix decimal constant description

On Wed, Jun 5, 2013 at 4:53 PM, Michal Simek <monstr@...str.eu> wrote:
> any comment on this?
>
> Geert: I fixes one warning reported in your regression log.

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> On 05/23/2013 08:03 AM, Michal Simek wrote:
>> Use proper decimal type for comparison with u32.
>>
>> Compilation warning was introduced by:
>> "audit: Make testing for a valid loginuid explicit."
>> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>>
>> Warning:
>> kernel/auditfilter.c: In function 'audit_data_to_entry':
>> kernel/auditfilter.c:426:3: warning: this decimal constant
>> is unsigned only in ISO C90 [enabled by default]
>>    if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> CC: Al Viro <viro@...iv.linux.org.uk>
>> CC: Eric Paris <eparis@...hat.com>
>> ---
>>  kernel/auditfilter.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 83a2970..cfa1f73 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
>>               f->lsm_rule = NULL;
>>
>>               /* Support legacy tests for a valid loginuid */
>> -             if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>> +             if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
>>                       f->type = AUDIT_LOGINUID_SET;
>>                       f->val = 0;
>>               }
>> --
>> 1.8.2.3
>>
>
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>



--
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/