linux-kernel - Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Jun 2013 23:59:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq
 files

On Tue, 2013-06-25 at 12:14 +0530, Viresh Kumar wrote:
> On 25 June 2013 09:45, Joe Perches <joe@...ches.com> wrote:
> > Viresh, there's no absolute "right" way to do this.
> 
> Yeah Joe, but I thought its better to keep it consistent within a file.
> So, while writing new files, keep what you want but for existing ones
> follow what's in there.

Sure Viresh.

I could agree with that, but that's not what you
recommended though.  "Check this everywhere" isn't
the same as the advice you just gave above.

There are those that think it's better to convert
each instance whenever touched to what they think
of as "kernel" style.

Me, I'd just as soon convert to aligned indentation
and generic kernel style whenever touching any code,
even if it differs from the existing file style.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/