linux-kernel - [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130625090253.26584.65072.stgit@aruna-ThinkPad-T420>
Date:	Tue, 25 Jun 2013 14:33:56 +0530
From:	Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
To:	tony.luck@...el.com, linux-kernel@...r.kernel.org
Cc:	jkenisto@...ux.vnet.ibm.com, ananth@...ibm.com,
	mahesh@...ux.vnet.ibm.com, cbouatmailru@...il.com,
	ccross@...roid.com, keescook@...omium.org
Subject: [PATCH v2] pstore: Fail to unlink if a driver has not defined
 pstore_erase

pstore_erase is used to erase the record from the persistent store.
So if a driver has not defined pstore_erase callback return
-EPERM instead of unlinking a file as deleting the file without
erasing its record in persistent store will give a wrong impression
to customers.

Signed-off-by: Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
---
Changes from v1:
	Fix error return value

 fs/pstore/inode.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index e4bcb2c..bfd95bf 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -178,6 +178,8 @@ static int pstore_unlink(struct inode *dir, struct dentry *dentry)
 	if (p->psi->erase)
 		p->psi->erase(p->type, p->id, p->count,
 			      dentry->d_inode->i_ctime, p->psi);
+	else
+		return -EPERM;
 
 	return simple_unlink(dir, dentry);
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/