linux-kernel - Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKSMtaLsTGYqpxnEM-dW+99SYhE1+SzLsD3gngxhxYN7w@mail.gmail.com>
Date:	Tue, 25 Jun 2013 09:41:03 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
Cc:	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>, jkenisto@...ux.vnet.ibm.com,
	ananth@...ibm.com, mahesh@...ux.vnet.ibm.com,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Colin Cross <ccross@...roid.com>
Subject: Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
<aruna@...ux.vnet.ibm.com> wrote:
> pstore_erase is used to erase the record from the persistent store.
> So if a driver has not defined pstore_erase callback return
> -EPERM instead of unlinking a file as deleting the file without
> erasing its record in persistent store will give a wrong impression
> to customers.
>
> Signed-off-by: Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/