linux-kernel - Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1306271147150.3538@pobox.suse.cz>
Date:	Thu, 27 Jun 2013 11:47:39 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	David Herrmann <dh.herrmann@...il.com>,
	linux-input@...r.kernel.org,
	Todd Showalter <todd@...ctronjump.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] input: document gamepad API and add extra
 keycodes

On Wed, 26 Jun 2013, Dmitry Torokhov wrote:

> On Sat, Jun 15, 2013 at 03:32:44PM +0200, David Herrmann wrote:
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -507,10 +507,14 @@ struct input_keymap_entry {
> >  
> >  #define BTN_GAMEPAD		0x130
> >  #define BTN_A			0x130
> > +#define BTN_SOUTH		0x130
> 
> Could we do:
> 
> #define BTN_SOUTH		0x130
> #define BTN_A			BTN_SOUTH
> 
> so that it is clear that BTN_A, BTN_B, etc are legacy definitions and
> not an accidental typos that need their own key codes.

Makes sense, will do that modification.

> Otherwise:
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Thanks Dmitry. Will be taking it (with the above modification) through my 
tree.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/