[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20130628104548.GL10727@linux-mips.org>
Date: Fri, 28 Jun 2013 12:45:49 +0200
From: Ralf Baechle <ralf@...ux-mips.org>
To: Maxim Uvarov <muvarov@...il.com>
Cc: David Daney <ddaney.cavm@...il.com>,
Wladislav Wiebe <wladislav.kw@...il.com>,
david.daney@...ium.com, davem@...emloft.net,
linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] MIPS: Octeon: fix for held reboot_mutex lock at
task exit time
Sorry for the late reply - this ended up in the moderator queue for the
mailing list and I rarely look at it - it's tens of thousands of emails!
On Thu, May 23, 2013 at 11:58:34PM +0400, Maxim Uvarov wrote:
> >> diff --git a/arch/mips/cavium-octeon/**setup.c b/arch/mips/cavium-octeon/
> >> **setup.c
> >> index b0baa29..04ce396 100644
> >> --- a/arch/mips/cavium-octeon/**setup.c
> >> +++ b/arch/mips/cavium-octeon/**setup.c
> >> @@ -457,6 +457,10 @@ static void octeon_halt(void)
> >> }
> >>
> >> octeon_kill_core(NULL);
> >> +
> >> + /* We stop here */
> >> + while (1)
> >> + ;
> >>
> >
> > I want to put a WAIT here so we don't burn so much power.
> >
> > I will send a patch to do that instead.
> >
> >
> what about adding wait for other mips boards where is while (1) is used?
Many platforms have their own variants of eternal loops, some using
just "while (1);", others trying to save power using the WAIT instruction.
I was planing to work through all of them and come up with a common
defaut implementation.
Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists