lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Jul 2013 13:45:16 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Ramkumar Ramachandra <artagnon@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, Dave Young <dyoung@...hat.com> Subject: Re: [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run On Sun, 30 Jun 2013 18:23:11 +0530 Ramkumar Ramachandra <artagnon@...il.com> wrote: > The cpu-hotplug and memory-hotplug tests don't run: > > $ sudo make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests > /bin/sh: ./on-off-test.sh: Permission denied > > $ sudo make -C tools/testing/selftests TARGETS=memory-hotplug run_tests > /bin/sh: ./on-off-test.sh: Permission denied > > Flip the executable bit fixing this. > > ... > > 2 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/cpu-hotplug/on-off-test.sh > mode change 100644 => 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh > > diff --git a/tools/testing/selftests/cpu-hotplug/on-off-test.sh b/tools/testing/selftests/cpu-hotplug/on-off-test.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/memory-hotplug/on-off-test.sh b/tools/testing/selftests/memory-hotplug/on-off-test.sh > old mode 100644 > new mode 100755 That won't work. The x bit will too easily get lost again - for example, patch(1) will rub it out. This: --- a/tools/testing/selftests/cpu-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts +++ a/tools/testing/selftests/cpu-hotplug/Makefile @@ -1,6 +1,6 @@ all: run_tests: - @./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]" + @/bin/sh ./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]" clean: --- a/tools/testing/selftests/memory-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts +++ a/tools/testing/selftests/memory-hotplug/Makefile @@ -1,6 +1,6 @@ all: run_tests: - @./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]" + @/bin/sh ./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]" clean: _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists