linux-kernel - Re: [RFC] wlcore: sdio: add wilink clock providers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130701204633.GB805@arwen.pp.htv.fi>
Date:	Mon, 1 Jul 2013 23:46:33 +0300
From:	Felipe Balbi <balbi@...com>
To:	Luciano Coelho <coelho@...com>
CC:	<mturquette@...aro.org>, <mark.rutland@....com>, <balbi@...com>,
	<grant.likely@...aro.org>, <rob.herring@...xeda.com>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<--linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC] wlcore: sdio: add wilink clock providers

Hi,

On Mon, Jul 01, 2013 at 10:34:10PM +0300, Luciano Coelho wrote:
> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> index 670c3ce..7f061b8 100644
> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
> @@ -65,11 +65,19 @@
>  		enable-active-high;
>  	};
>  
> +
>  	wlan {
> -	     compatible = "ti,wilink6";
> -	     interrupt-parent = <&gpio2>;
> -	     interrupts = <21 0x4>;	/* gpio line 53, high level triggered */
> -	     refclock = <2>;		/* 38.4 MHz */
> +		compatible = "ti,wilink6";
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <21 0x4>;	/* gpio line 53, high level triggered */
> +		clocks = <&refclock>;
> +		clock-names = "refclock";

hmmm, shouldn't you provide both clocks (refclock and tcx0clock)
explicitly here ?

Also, you should probably make it clear that the WiLink module is fed by
the 32K sync clock just to make sure clock usecounts are correctly
incremented ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)