linux-kernel - Re: [PATCHv2] drivers: spi: Add qspi flash controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130702110432.GJ27646@sirena.org.uk>
Date:	Tue, 2 Jul 2013 12:04:32 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Felipe Balbi <balbi@...com>
Cc:	Sourav Poddar <sourav.poddar@...com>,
	spi-devel-general@...ts.sourceforge.net, grant.likely@...aro.org,
	rnayak@...com, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] drivers: spi: Add qspi flash controller

On Tue, Jul 02, 2013 at 01:43:38PM +0300, Felipe Balbi wrote:
> On Tue, Jul 02, 2013 at 11:17:18AM +0100, Mark Brown wrote:

> > +	/* setup command reg */
> > +	qspi->cmd = 0;
> > +	qspi->cmd |= QSPI_WLEN(8);

> Sourav hardcodes wordlenght to 8-bits, and yet he enables 8, 16 and
> 32-bits per word.

Yeah, that's what I noticed (well first off I noticed that there were no
constraints on bits per word at all).

> > +	qspi->cmd |= QSPI_EN_CS(0);

> he's also hardcoding the chipselect line which should be take from
> m->spi->chip_select

This one *can* be OK if the driver only accepts one chip select (though
obviously supporting more is better).  I'd really only done a fairly
high level review for framework stuff so hadn't got that far yet.

One thing I really want to get round to doing with the SPI core is
providing an easy to pick up GPIO chip select as standard 

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)