linux-kernel - Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130702200147.GC9359@redhat.com>
Date:	Tue, 2 Jul 2013 22:01:47 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where
	appropriate

On 07/01, Denys Vlasenko wrote:
>
> Grepping for numeric constants is inconvenient.

Personally I agree very much, and I like the intent.

> +#define WTERMSIG_MASK     0x7f
> +#define WTERMSIG(status)  ((status) & WTERMSIG_MASK)
> +#define WCOREDUMP(status) ((status) & 0x80)

But I am not sure we need WTERMSIG/WCOREDUMP helpers, although
I won't really argue.

OTOH, I think it would be nice to add the name for 0x80 and
change coredump_finish().

And if we do not add WTERMSIG(), then perhaps we can turn other
0x7f's into WTERMSIG_MASK?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/