linux-kernel - Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK1hOcNxG7qW73Q2cr56XfFG-+60HS-M-TrdwniVRtag8YY+Cg@mail.gmail.com>
Date:	Thu, 4 Jul 2013 11:03:41 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate

On Tue, Jul 2, 2013 at 10:01 PM, Oleg Nesterov <oleg@...hat.com> wrote:
> On 07/01, Denys Vlasenko wrote:
>>
>> Grepping for numeric constants is inconvenient.
>
> Personally I agree very much, and I like the intent.
>
>> +#define WTERMSIG_MASK     0x7f
>> +#define WTERMSIG(status)  ((status) & WTERMSIG_MASK)
>> +#define WCOREDUMP(status) ((status) & 0x80)
>
> But I am not sure we need WTERMSIG/WCOREDUMP helpers, although
> I won't really argue.

Are you saying that you prefer just mask constants,
do not want macros?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/