linux-kernel - Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51D3D969.1060308@atmel.com>
Date:	Wed, 3 Jul 2013 15:57:29 +0800
From:	Bo Shen <voice.shen@...el.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
CC:	Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
	<richard.genoud@...il.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	<linux-kernel@...r.kernel.org>, <linux-sound@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine
 framework

Hi Lars,

On 7/3/2013 15:36, Lars-Peter Clausen wrote:
>>>> +        slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
>>> >>[...]
>>>> >>>+        slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
>>> >>
>>> >>Change the type of phybase to dma_addr_t
>> >
>> >It should be:
>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR);
>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR);
> The type of phybase in the ssc_device struct should be changed from
> resource_size_t to dma_addr_t.

Actually, the phybase in ssc_device structure is resource_size_t which 
used to access the ssc device register.
Here, we use ssc register as dma source address or destination address, 
so we convert it to dma_addr_t type. So, not need to change, am I right?

Best Regards,
Bo Shen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/