lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Jul 2013 17:04:55 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>, Yinghai Lu <yinghai@...nel.org>, john.ronciak@...el.com, miles.j.penner@...el.com, bruce.w.allan@...el.com, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Mika Westerberg <mika.westerberg@...ux.intel.com>, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org, x86@...nel.org Subject: [PATCH v2 8/8] PCI: acpiphp: sanitize acpiphp_get_[latch|adapter]_status() There is no need for a temporary variable and all the tricks with ternary operators. Change the functions to be a bit more straightforward. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com> --- drivers/pci/hotplug/acpiphp_glue.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 506f38f..810ca4c 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -1271,11 +1271,7 @@ u8 acpiphp_get_power_status(struct acpiphp_slot *slot) */ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot) { - unsigned int sta; - - sta = get_slot_status(slot); - - return (sta & ACPI_STA_DEVICE_UI) ? 0 : 1; + return !(get_slot_status(slot) & ACPI_STA_DEVICE_UI); } @@ -1285,9 +1281,5 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot) */ u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot) { - unsigned int sta; - - sta = get_slot_status(slot); - - return (sta == 0) ? 0 : 1; + return !!get_slot_status(slot); } -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists