linux-kernel - Re: [PATCH 4/4] regulator: s2mps11: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130703180033.GX27646@sirena.org.uk>
Date:	Wed, 3 Jul 2013 19:00:33 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Yadwinder Singh Brar <yadi.brar@...sung.com>
Cc:	linux-kernel@...r.kernel.org, yadi.brar01@...il.com,
	sbkim73@...sung.com, lgirdwood@...il.com, sameo@...ux.intel.com,
	rob.herring@...xeda.com, grant.likely@...aro.org
Subject: Re: [PATCH 4/4] regulator: s2mps11: Add device tree support

On Mon, Jun 24, 2013 at 04:50:58PM +0530, Yadwinder Singh Brar wrote:

> +static void s2mps11_pmic_parse_dt(struct of_regulator_match *rdata,
> +					struct s2mps11_info *s2mps11)
> +{
> +	if (!of_find_property(rdata[S2MPS11_BUCK2].of_node,
> +				"regulator-ramp-disable", NULL))
> +		s2mps11->buck2_ramp = true;

This property should be specific to this binding rather than named as a
generic regulator property.  It's also a bit odd that setting a property
called "regulator-ramp-disable" causes the flag buckN_ramp to be set to
true - if the ramp is being disabled I'd expect a flag with that name to
be false not true.  Seems something isn't named right.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)