linux-kernel - Re: [PATCH 3/4] mfd: s2mps11: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130703180511.GA374@sirena.org.uk>
Date:	Wed, 3 Jul 2013 19:05:11 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Yadwinder Singh Brar <yadi.brar@...sung.com>
Cc:	linux-kernel@...r.kernel.org, yadi.brar01@...il.com,
	sbkim73@...sung.com, lgirdwood@...il.com, sameo@...ux.intel.com,
	rob.herring@...xeda.com, grant.likely@...aro.org
Subject: Re: [PATCH 3/4] mfd: s2mps11: Add device tree support

On Mon, Jun 24, 2013 at 04:50:57PM +0530, Yadwinder Singh Brar wrote:

> + regulator-ramp-delay for BUCKs = [6250/12500/25000(default)/50000] uV/us

> + Optional property for BUCK[2/3/4/6] only:
> + regulator-ramp-disable: boolean, disables ramp delay on hardware.

If these were device specific bindings they ought to be namespaced as
samsung, or similar.  However I think they are generic enough that they
could just be added to the standard regulator bindings, ramp rates are
common enough and units of time are a simple way to express them.  I'd
also suggest just using a ramp delay of zero for no ramp, it's simpler
and will probably fall naturally out of the bindings.

Please just send a separate patch adding these to the generic regulator
binding document instead of this one, we can add generic code/ops for
this later.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)