[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130703182748.GA18898@dyad.programming.kicks-ass.net>
Date: Wed, 3 Jul 2013 20:27:48 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Mel Gorman <mgorman@...e.de>
Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
Ingo Molnar <mingo@...nel.org>,
Andrea Arcangeli <aarcange@...hat.com>,
Johannes Weiner <hannes@...xchg.org>,
Linux-MM <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/13] sched: Favour moving tasks towards nodes that
incurred more faults
On Wed, Jul 03, 2013 at 03:21:36PM +0100, Mel Gorman wrote:
> static bool migrate_improves_locality(struct task_struct *p, struct lb_env *env)
> {
> + if (p->numa_faults[task_faults_idx(dst_nid, 1)] >
> + p->numa_faults[task_faults_idx(src_nid, 1)])
> + return true;
> +}
> +static bool migrate_degrades_locality(struct task_struct *p, struct lb_env *env)
> +{
> + if (p->numa_faults[src_nid] > p->numa_faults[dst_nid])
> return true;
I bet you wanted to use task_faults_idx() there too ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists