linux-kernel - Re: [GIT PULL] perf changes for v3.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwJwYRbPBBN1ma8TBHuomo_AJjajxT6YDmdGXJdE4EgrQ@mail.gmail.com>
Date:	Tue, 2 Jul 2013 17:50:29 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...nel.org>,
	Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] perf changes for v3.11

On Mon, Jul 1, 2013 at 2:03 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-core-for-linus
>
> Kernel improvements:
>
>  * AMD IOMMU uncore PMU support by Suravee Suthikulpanit001a

This one prints a really annoying error message if you're not on an
AMD platform:

+       if (!amd_iommu_pc_supported()) {
+               pr_err("perf: amd_iommu PMU not installed. No support!\n");
+               return -ENODEV;
+       }

and you know what? That's not acceptable. It damn well is *not* an
error to not have an AMD IOMMU.

It should - at most - be a pr_info(). Maybe nothing at all. "pr_err()"
is just totally out of line.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/