linux-kernel - Re: [PATCH 3/4] mfd: s2mps11: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130704092249.GK27646@sirena.org.uk>
Date:	Thu, 4 Jul 2013 10:22:49 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Yadwinder Singh Brar <yadi.brar01@...il.com>
Cc:	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	linux-kernel@...r.kernel.org, sbkim73@...sung.com,
	Liam Girdwood <lgirdwood@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 3/4] mfd: s2mps11: Add device tree support

On Thu, Jul 04, 2013 at 10:37:30AM +0530, Yadwinder Singh Brar wrote:

> -  Currently ramp-delay (= 0) if not defined in DT, leaves the
> hardware with default

That's just an issue in the code if that is the case, you can test for
the presence of a property independently of getting its value.

> - As ramp time is inversely propositional to ramp-rate(i.e. ramp-delay ,
> its wrongly named, my mistake :( ) so it may look weired to use ramp-rate =0
> as no ramp(ramp_time = 0).

I think it's fairly obvious what's going on there, it fits in with the
general pattern that a lower number is faster too.

> I had below idea in my mind, I dropped it because I thought it may be
> to early to put common code as no other driver in mainline appeared
> with this requirement yet but probably may come.

There are plenty of drivers that could configure this, it's just that
it's normally done either in hardware or the bootloader rather than by
the OS.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)