linux-kernel - Re: [PATCH 4/4] regulator: s2mps11: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Jul 2013 10:23:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Yadwinder Singh Brar <yadi.brar01@...il.com>
Cc:	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	linux-kernel@...r.kernel.org, sbkim73@...sung.com,
	Liam Girdwood <lgirdwood@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH 4/4] regulator: s2mps11: Add device tree support

On Thu, Jul 04, 2013 at 10:44:36AM +0530, Yadwinder Singh Brar wrote:

> Yes, it seems incorrect but in existing code based on pdata, its name like that.
> If you insist, I can rename it ? as It seems sensible to put
> "regulator-ramp-disable" as our intension is to do that(by default its
> always enable).

It seems sensible to rename yes, otherwise this code just looks totally
wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)