linux-kernel - Re: [PATCH] N900: add device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130704171939.GA27374@blackmetal.musicnaut.iki.fi>
Date:	Thu, 4 Jul 2013 20:19:39 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Pavel Machek <pavel@....cz>
Cc:	Tony Lindgren <tony@...mide.com>, b-cousson@...com,
	pali.rohar@...il.com, kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH] N900: add device tree

On Mon, Jul 01, 2013 at 11:17:54PM +0200, Pavel Machek wrote:
> This adds device tree with neccessary support to boot with functional
> video (on both emulator and real N900 device).

Is this really correct? You have commented out the USB, so there is no
way for a developer to interact with the device.

Some minor issue too:

> +/*
> + * Copyright (C) 2013 Pavel Machek <pavel@....cz>
> + * Copyright 2013 Aaro Koskinen <aaro.koskinen@....fi>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 (or later) as
> + * published by the Free Software Foundation.

Should be just GPLv2.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/