linux-kernel - Re: [PATCH v5 00/12] Lockless update of reference count protected by spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51D6E6D9.4010201@hp.com>
Date:	Fri, 05 Jul 2013 11:31:37 -0400
From:	Waiman Long <waiman.long@...com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Jeff Layton <jlayton@...hat.com>,
	Miklos Szeredi <mszeredi@...e.cz>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Chandramouleeswaran, Aswin" <aswin@...com>,
	"Norton, Scott J" <scott.norton@...com>
Subject: Re: [PATCH v5 00/12] Lockless update of reference count protected
 by spinlock

On 07/05/2013 11:29 AM, Waiman Long wrote:
> On 07/05/2013 11:02 AM, Al Viro wrote:
>> On Fri, Jul 05, 2013 at 10:47:33AM -0400, Waiman Long wrote:
>>> v4->v5:
>>>   - Add a d_count() helper for readonly access of reference count and
>>>     change all references to d_count outside of dcache.c, dcache.h
>>>     and namei.c to use d_count().
>> Sigh...  You are breaking bisectability again.  This helper should
>> be introduced *first*, along with conversion to it.  Then you can
>> do the rest on top of that.
>>
>> I've just pushed such commit into vfs.git#for-linus; please, do the rest
>> on top of it.  And keep it bisectable, i.e. so that at any intermediate
>> point the tree would build and work.
>
> I am sorry. I didn't change anything in the dentry structure in patch 
> 3. So putting patches 4-11 on top of it won't break the build.

I explicitly applied the patches one at a time to make sure that there 
was no broken build.

Regards,
Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/