linux-kernel - Re: [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <239047.1373249476@turing-police.cc.vt.edu>
Date:	Sun, 07 Jul 2013 22:11:16 -0400
From:	Valdis.Kletnieks@...edu
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	akpm@...ux-foundation.org, axboe@...nel.dk, oakad@...oo.com,
	tj@...nel.org, mm-commits@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree

On Mon, 08 Jul 2013 03:41:42 +0300, Maxim Levitsky said:

> +/* Debug test to validate free block counts */
> +#ifdef DEBUG
> +static int msb_validate_used_block_bitmap(struct msb_data *msb)
> +{

Is there a reason this should be inside a #ifdef DEBUG with no
easy way to select DEBUG?  Maybe CONFIG_MS_BLOCK_DEBUG similar to
the way other subsystems allow configuring additional debug code?

Content of type "application/pgp-signature" skipped