linux-kernel - Re: [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1373292716.32554.5.camel@maxim-laptop>
Date:	Mon, 08 Jul 2013 17:11:56 +0300
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Valdis.Kletnieks@...edu
Cc:	akpm@...ux-foundation.org, axboe@...nel.dk, oakad@...oo.com,
	tj@...nel.org, mm-commits@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [merged] memstick-add-support-for-legacy-memorysticks.patch
 removed from -mm tree

On Sun, 2013-07-07 at 22:11 -0400, Valdis.Kletnieks@...edu wrote: 
> On Mon, 08 Jul 2013 03:41:42 +0300, Maxim Levitsky said:
> 
> > +/* Debug test to validate free block counts */
> > +#ifdef DEBUG
> > +static int msb_validate_used_block_bitmap(struct msb_data *msb)
> > +{
> 
> Is there a reason this should be inside a #ifdef DEBUG with no
> easy way to select DEBUG?  Maybe CONFIG_MS_BLOCK_DEBUG similar to
> the way other subsystems allow configuring additional debug code?

Unless there is a bug in the driver, the code shouldn't really be
needed.
I have a module param 'debug' and I don't mind hooking this code to it.

But I don't mind hooking this code to 'debug' module param I have.
I updated this, and fixed deprecated usage of idr_pre_get.

Updated version attached.


-- 
Best regards,
        Maxim Levitsky



View attachment "0001-memstick-add-support-for-legacy-memorysticks.patch" of type "text/x-patch" (71510 bytes)