linux-kernel - Re: [PATCH net-next] r8169: add a new chip for RTL8411

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Jul 2013 17:43:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	hayeswang@...ltek.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: add a new chip for RTL8411

From: Francois Romieu <romieu@...zoreil.com>
Date: Wed, 10 Jul 2013 01:00:16 +0200

> David Miller <davem@...emloft.net> :
> [...]
>> Francois, please review.
> 
> The style is consistent with the driver.
> 
> The commit message may state that this 8411 chipset does not require
> any special action in rtl_link_chg_patch (whence differing from the
> previous "F" 8411).
> 
> Most of the code shared by rtl_hw_start_8168g_2 and rtl_hw_start_8411_2
> is already factored out. There is not much to win here.
> 
> The new RTL_GIGA_MAC_VER_XY id is added in the required places.
> 
> It builds.
> 
> It's fine.

Thanks for reviewing, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/