linux-kernel - Re: [RFC 0/4] perf tools: Remove event types data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3kxy5xz.fsf@sejong.aot.lge.com>
Date:	Thu, 11 Jul 2013 15:19:20 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	David Ahern <dsahern@...il.com>,
	Thomas Renninger <trenn@...e.de>
Subject: Re: [RFC 0/4] perf tools: Remove event types data

On Tue,  9 Jul 2013 18:48:55 +0200, Jiri Olsa wrote:
> hi,
> following up on the 'perf timechart' FIXME note and changing
> its tracepoint match not to use event types data.
>
> In my tests the old and new timechart outputs look the same,
> so.. any other tester would be appreciated ;-)
>
> Also as this was the only user of the event types data
> the rest of the patchset is removing it out of the perf.
>
> The event types data are referenced from the perf data
> file header. The reference (offset & size) stays in the
> header with 0s.
>
> Also the event types data is already duplicated via the
> event_desc FEATURE, so there's no information loss.

I generally agree on removing the event_types but have a couple of
issues on patch 1.  Please see my comments on it.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/