linux-kernel - Re: [PATCH V2] pci: exynos: split into two parts such as Synopsys part and Exynos part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jul 2013 10:15:30 -0700
From:	Thierry Reding <thierry.reding@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Bjorn Helgaas' <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	'Kukjin Kim' <kgene.kim@...sung.com>,
	'Pratyush Anand' <pratyush.anand@...com>,
	'Mohit KUMAR' <Mohit.KUMAR@...com>,
	'Arnd Bergmann' <arnd@...db.de>,
	'Sean Cross' <xobs@...agi.com>,
	'Kishon Vijay Abraham I' <kishon@...com>,
	'SRIKANTH TUMKUR SHIVANAND' <ts.srikanth@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] pci: exynos: split into two parts such as Synopsys
 part and Exynos part

On Fri, Jul 12, 2013 at 08:28:05AM +0900, Jingoo Han wrote:
> On Friday, July 12, 2013 12:41 AM, Thierry Reding wrote:
> > On Thu, Jul 11, 2013 at 02:49:43PM +0900, Jingoo Han wrote:
> > [...]
> > > diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
> > [...]
> > >  obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o
> > >  obj-$(CONFIG_PCIE_DW) += pcie-designware.o
> > > +obj-$(CONFIG_PCI_EXYNOS) += pcie-exynos.o
> > 
> > I think we should keep these sorted alphabetically. Also Tegra and
> > Marvell are PCIe controllers but they still use the pci- prefix instead
> > of pcie-. Perhaps it'd be good to keep consistency here? I initially
> > chose pci- because from a software point of view it doesn't matter all
> > that much whether it's PCI or PCIe and because the drivers are part of
> > the PCI subsystem. However if Exynos now uses the pcie- prefix it makes
> > it look like Tegra and Marvell are plain old PCI.
> > 
> 
> Hi Thierry,
> 
> I initially chose 'pci-' prefix such as 'pci-designware.c'.
> 
> However, Pratyush Anand suggested as below:
> "I would suggest to rename it as pcie-designware.c,
> because synopsis pcie and pci controllers are different."
> 
> If you have a good idea, please give it to me. :)

Alternatively the plain old PCI variant could be suffixed -legacy or
similar, but I guess pcie- as a prefix works okay in this case.

However I still think you should sort them properly:

	obj-$(CONFIG_PCIE_DW) += pcie-designware.o
	obj-$(CONFIG_PCI_EXYNOS) += pci-exynos.o
	obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)