linux-kernel - Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwTSXAt=GV=7WuX0yrJpHsFK=WbbDaRJbvvdejsWA0aOg@mail.gmail.com>
Date:	Mon, 15 Jul 2013 10:49:51 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Steven Miao <realmz6@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.11

On Mon, Jul 15, 2013 at 10:28 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>
> but the first one is non-trivial: using xchg() on atomic_t is a bit gross...

It's also broken. There's no guarantee that an "atomic_t" is just a
value. Now, the old sparc32 stuff (which hid lock bits in atomic_t)
may be gone, but it's still the case that atomic_t may not actually
work with xchg.

(In *practice* it works on normal architectures, so I'm not saying
that we don't have it, but it's a bug if we do).

There are "atomic_xchg()" and "atomic_xchg64()" functions that are supported.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/