linux-kernel - Re: [PATCH] perf, tools, bench: Fix memcpy benchmark for large sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130716142010.GR5643@tassilo.jf.intel.com>
Date:	Tue, 16 Jul 2013 07:20:10 -0700
From:	Andi Kleen <ak@...ux.jf.intel.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.jf.intel.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...radead.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.jf.intel.com>,
	h.mitake@...il.com, kirill.shutemov@...ux.jf.intel.com
Subject: Re: [PATCH] perf, tools, bench: Fix memcpy benchmark for large sizes

> > @@ -117,6 +117,8 @@ static void alloc_mem(void **dst, void **src, size_t length)
> >  	*src = zalloc(length);
> >  	if (!src)
> >  		die("memory allocation failed - maybe length is too large?\n");
> > +	/* Make sure to always replace the zero pages even if MMAP_THRESH is crossed */
> > +	memset(src, 0, length);
> 
> It should be memset(*src, 0, length) instead.

Thanks for catching. I wonder why it fixed the problem for me.

> There's fix for wrong memory allocation fail check in v3.11-rc1.

Doubt it matters.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/