linux-kernel - Re: [kconfig] results of some syntactical checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374042658.26384.31.camel@x61.thuisdomein>
Date:	Wed, 17 Jul 2013 08:30:58 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Martin Walch <walch.martin@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [kconfig] results of some syntactical checks

On Wed, 2013-07-17 at 01:18 +0200, Paul Bolle wrote:
> On Wed, 2013-07-17 at 00:34 +0200, Martin Walch wrote:
> >   Symbol: M at
> >     drivers/usb/host/Kconfig:568:0
> >     drivers/usb/misc/Kconfig:130:0
> 
> This looks odd. I think your checker doesn't like an uppercase M after
> default. There are exactly two of those in the tree.

After posting this I actually looked into this and even tested it a bit.
It turns out an uppercase 'M' isn't a valid alias for the magic 'm'
value. Your checker is right about warning for this.

> >   Symbol: N at
> >     drivers/usb/core/Kconfig:12:0
> >     drivers/usb/host/Kconfig:336:0
> >     drivers/usb/host/Kconfig:348:0
> >     drivers/staging/usbip/Kconfig:3:0
> >     drivers/staging/usbip/Kconfig:20:0
> >     drivers/staging/usbip/Kconfig:31:0
> >     drivers/staging/usbip/Kconfig:42:0
> >     drivers/staging/asus_oled/Kconfig:3:0
> >     drivers/staging/rtl8187se/Kconfig:8:0
> >     drivers/staging/rtl8192u/Kconfig:7:0
> >     drivers/staging/rtl8192e/rtl8192e/Kconfig:7:0
> >     drivers/staging/rtl8712/Kconfig:6:0
> >     drivers/staging/rtl8712/Kconfig:14:0
> >     drivers/staging/frontier/Kconfig:3:0
> >     drivers/staging/bcm/Kconfig:3:0
> >     drivers/staging/media/go7007/Kconfig:15:0
> >     drivers/staging/media/go7007/Kconfig:26:0
> >     drivers/staging/media/go7007/Kconfig:48:0
> >     drivers/staging/android/Kconfig:4:0
> >     drivers/staging/android/Kconfig:61:0
> >     arch/cris/arch-v32/drivers/Kconfig:13:0
> >     arch/cris/arch-v32/drivers/Kconfig:413:0
> >     arch/arc/Kconfig:357:0
> 
> Ditto (but I haven't actually counted the occurrences of "default N").

Lowercase 'n' is the correct magic value. But using uppercase 'N'
doesn't matter. Since there's no Kconfig symbol "N", both evaluate to
"not set" and you'll end up with the same .config file.

> My script currently finds 28 undefined symbols. That equals this result
> (given you have 2 false positive and 1 undefined choice default.)

So those 2 were actually correct positives.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/