linux-kernel - Re: [PATCH v2] x86/pci: checkpatch.pl cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130717075813.GA14629@gmail.com>
Date:	Wed, 17 Jul 2013 09:58:13 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Valentina Manea <valentina.manea.m@...il.com>, bhelgaas@...gle.com
Cc:	linux-kernel@...r.kernel.org, bin.gao@...ux.intel.com,
	gregkh@...uxfoundation.org, bhelgaas@...gle.com, x86@...nel.org,
	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de
Subject: Re: [PATCH v2] x86/pci: checkpatch.pl cleanup


* Valentina Manea <valentina.manea.m@...il.com> wrote:

> This patch fixes warning and errors found by checkpatch.pl:
> 
> * replace asm/acpi.h, asm/io.h and asm/smp.h with linux/acpi.h,
> linux/io.h and linux/smp.h respectively
> * remove explicit initialization to 0 of a static global variable
> * replace printk(KERN_INFO ...) with pr_info
> * use tabs instead of spaces for indentation
> * arrange comments so that they adhere to Documentation/CodingStyle
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@...il.com>

Looks good, thanks.

Bjorn, I can pick this up into tip:x86/cleanups, or would you like to put 
this into the PCI tree?

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/