linux-kernel - Re: [PATCH v2] x86/pci: checkpatch.pl cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAErSpo4s2DU0AMJBE5twDcDvbUXcT=OqAKCRJUt4H5cqEqyokg@mail.gmail.com>
Date:	Fri, 19 Jul 2013 15:25:04 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Valentina Manea <valentina.manea.m@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bin Gao <bin.gao@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2] x86/pci: checkpatch.pl cleanup

On Wed, Jul 17, 2013 at 1:58 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Valentina Manea <valentina.manea.m@...il.com> wrote:
>
>> This patch fixes warning and errors found by checkpatch.pl:
>>
>> * replace asm/acpi.h, asm/io.h and asm/smp.h with linux/acpi.h,
>> linux/io.h and linux/smp.h respectively
>> * remove explicit initialization to 0 of a static global variable
>> * replace printk(KERN_INFO ...) with pr_info
>> * use tabs instead of spaces for indentation
>> * arrange comments so that they adhere to Documentation/CodingStyle
>>
>> Signed-off-by: Valentina Manea <valentina.manea.m@...il.com>
>
> Looks good, thanks.
>
> Bjorn, I can pick this up into tip:x86/cleanups, or would you like to put
> this into the PCI tree?

I added your ack, capitalized "PCI", "Langwell", etc. consistently,
and put it in my pci/misc branch.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/