linux-kernel - Re: [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E6AEC2.3050308@metafoo.de>
Date:	Wed, 17 Jul 2013 16:48:34 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Oleksandr Kozaruk <oleksandr.kozaruk@...com>, tony@...mide.com,
	benoit.cousson@...aro.org, rnayak@...com, peter.ujfalusi@...com,
	kishon@...com, jic23@....ac.uk, grant.likely@...aro.org,
	rob.herring@...xeda.com, sameo@...ux.intel.com,
	ch.naveen@...sung.com, poeschel@...onage.de, milo.kim@...com,
	balajitk@...com, gg@...mlogic.co.uk, linux-iio@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 1/2] ARM: dts: twl: Add GPADC data to device tree

On 07/17/2013 04:33 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 17-07-2013 15:12, Oleksandr Kozaruk wrote:
> 
>> GPADC is the general purpose ADC present on twl6030.
>> The dt data is interrupt used to trigger end of ADC
>> conversion.
> 
>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@...com>
>> ---
>>   arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
>> index 2e3bd31..322aa8e 100644
>> --- a/arch/arm/boot/dts/twl6030.dtsi
>> +++ b/arch/arm/boot/dts/twl6030.dtsi
>> @@ -103,4 +103,10 @@
>>           compatible = "ti,twl6030-pwmled";
>>           #pwm-cells = <2>;
>>       };
>> +
>> +    adc: twl6030_gpadc {
> 
>    I was talking about the device name, not label. The "twl6030_gpadc" part.

The compatible property should also be: 'twl6030-gpadc' instead of
'twl6030_gpadc' and you need to add documentation for it.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/