linux-kernel - Re: [PATCH 01/21] MFD: ti_tscadc: disable TSC control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130717173451.GB17882@kroah.com>
Date:	Wed, 17 Jul 2013 10:34:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Zubair Lutfullah <zubair.lutfullah@...il.com>
Cc:	jic23@....ac.uk, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, koen@...inion.thruhere.net
Subject: Re: [PATCH 01/21] MFD: ti_tscadc: disable TSC control

On Wed, Jul 17, 2013 at 06:26:30PM +0100, Zubair Lutfullah wrote:
> Register bits when TSC not in use

What does this mean?

> AFE Pen Ctrl and TouchScreen transistors enabling is not
> 
> required when only ADC mode is being used, so check for availability of
> 
> TSC driver before accessing control register.

What's with the extra newlines?

> 
> This patch is based on work in the 3.2 tree by TI
> Original Author is Patil Rachna

If you didn't write this, you need to put the "From: " line for the
correct author/email in the patch, as Documentation/SubmittingPatches
describes so that they can get the correct credit.

> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@...il.com>

What happened to Patil's signed-off-by: line?
Same goes for other patches in this series.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/