linux-kernel - Re: [PATCH 05/21] iio: input: am335x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jul 2013 10:38:01 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Zubair Lutfullah <zubair.lutfullah@...il.com>
Cc:	jic23@....ac.uk, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, koen@...inion.thruhere.net
Subject: Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

On Wed, Jul 17, 2013 at 06:26:34PM +0100, Zubair Lutfullah wrote:
> Main patch. Adds continuous sampling support for the driver

What does that mean?  Why have this in the changelog at all?

> 
> The IRQs are changed in the TSC drivers as they are shared with
> the ADC IRQ lines.
> 
> This patch is based on work in the 3.2 tree by TI
> Original Author is Patil Rachna
> 
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@...il.com>
> ---
>  drivers/iio/adc/ti_am335x_adc.c           |  386 ++++++++++++++++++++++++-----
>  drivers/input/touchscreen/ti_am335x_tsc.c |    9 +-
>  drivers/mfd/ti_am335x_tscadc.c            |   12 +-
>  include/linux/mfd/ti_am335x_tscadc.h      |   12 +
>  4 files changed, 351 insertions(+), 68 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index 8a63203..1f6e800 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -29,11 +29,25 @@
>  #include <linux/math64.h>
>  #include <linux/mfd/ti_am335x_tscadc.h>
>  
> +#include <linux/stat.h>
> +
> +#include <linux/sched.h>

Why extra newlines?

> +#include <linux/iio/buffer.h>
> +#include <linux/iio/trigger_consumer.h>
> +#include <linux/iio/kfifo_buf.h>
> +#include <linux/iio/sysfs.h>
> +#include <linux/delay.h>
> +
>  struct tiadc_device {
>  	struct ti_tscadc_dev *mfd_tscadc;
>  	int channels;
>  	u8 channel_line[8];
>  	u8 channel_step[8];
> +	struct work_struct      poll_work;
> +	wait_queue_head_t       wq_data_avail;
> +	int                     irq;
> +	bool                    is_continuous_mode;
> +        u16                     *buffer;

Please run all of these patches through checkpatch and fix the issues
that are reported, otherwise there is no way they can be accepted.

I've stopped reviewing this series here...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/