linux-kernel - Re: [PATCH 05/21] iio: input: am335x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130718080823.GB11251@arwen.pp.htv.fi>
Date:	Thu, 18 Jul 2013 11:08:23 +0300
From:	Felipe Balbi <balbi@...com>
To:	Zubair Lutfullah <zubair.lutfullah@...il.com>
CC:	<jic23@....ac.uk>, <linux-iio@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<koen@...inion.thruhere.net>
Subject: Re: [PATCH 05/21] iio: input: am335x_adc: Add continuous mode to adc

Hi,

On Wed, Jul 17, 2013 at 06:26:34PM +0100, Zubair Lutfullah wrote:
> Main patch. Adds continuous sampling support for the driver
> 
> The IRQs are changed in the TSC drivers as they are shared with
> the ADC IRQ lines.
> 
> This patch is based on work in the 3.2 tree by TI
> Original Author is Patil Rachna
> 
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@...il.com>

to me this patch looks incorrect. IIO framework provides a generic ring
buffer implementation which could be used for continuous mode. Adding
driver specific attributes isn't very nice IMO.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)