linux-kernel - Re: [PATCH 4/4] [media] em28xx: Fix vidioc fmt vid cap v4l2 compliance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201307181005.38765.hverkuil@xs4all.nl>
Date:	Thu, 18 Jul 2013 10:05:38 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Devin Heitmueller <dheitmueller@...nellabs.com>
Cc:	Alban Browaeys <alban.browaeys@...il.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alban Browaeys <prahal@...oo.com>
Subject: Re: [PATCH 4/4] [media] em28xx: Fix vidioc fmt vid cap v4l2 compliance

On Thu 18 July 2013 04:07:51 Devin Heitmueller wrote:
> On Tue, Jul 16, 2013 at 7:06 PM, Alban Browaeys
> <alban.browaeys@...il.com> wrote:
> > Set fmt.pix.priv to zero in vidioc_g_fmt_vid_cap
> >  and vidioc_try_fmt_vid_cap.
> 
> Any reason not to have the v4l2 core do this before dispatching to the
> driver?  Set it to zero before the core calls g_fmt.  This avoids all
> the drivers (most of which don't use the field) from having to set the
> value themselves.

There is still one driver (sn9c102) that's (ab)using it. Although perhaps I
should take a look at it and fix it.

Note that priv only needs to be cleared for try/s_fmt. g_fmt does clear it
already in the core before handing it over to the driver.

That said, I am undecided whether to put this in the core. We might actually
start to use this field for something useful in the future. By having drivers
clear it explicitly it will be easier to do that.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/