linux-kernel - Re: commit f8f559422b (KVM: MMU: fast invalidate all mmio sptes) causes hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B438F263-D5D5-4755-AAAA-ED92F4F0379E@gmail.com>
Date:	Thu, 18 Jul 2013 03:07:11 +0800
From:	Xiao Guangrong <xiaoguangrong.eric@...il.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	Gleb Natapov <gleb@...hat.com>, kvm@...r.kernel.org,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: commit f8f559422b (KVM: MMU: fast invalidate all mmio sptes) causes hang

Ouch!

The guest is hang when boot from ubuntu iso, i bisected the code and found it is caused by:

cad55f1aed000db46dfd1b5706707f33624d8604 is the first bad commit
commit cad55f1aed000db46dfd1b5706707f33624d8604
Author: Cornelia Huck <cornelia.huck@...ibm.com>
Date:   Wed Jul 3 16:30:53 2013 +0200

    KVM: kvm-io: support cookies
    
    Add new functions kvm_io_bus_{read,write}_cookie() that allows users of
    the kvm io infrastructure to use a cookie value to speed up lookup of a
    device on an io bus.
    
    Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>
    Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>

Now, i have reset the code behind this commit and continue to install the guest…...

On Jul 18, 2013, at 12:57 AM, Markus Trippelsdorf <markus@...ppelsdorf.de> wrote:

> On 2013.07.17 at 19:42 +0300, Gleb Natapov wrote:
>> On Wed, Jul 17, 2013 at 06:32:15PM +0200, Markus Trippelsdorf wrote:
>>> The following commit:
>>> commit f8f559422b6c6a05469dfde614b67789b6142cb5
>>> Author: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
>>> Date:   Fri Jun 7 16:51:26 2013 +0800
>>> 
>>>    KVM: MMU: fast invalidate all mmio sptes
>>> 
>>> causes my kvm qemu qcow2 images to hang when they switch from the boot
>>> console to the desktop. For example:
>>> qemu-system-x86_64 -enable-kvm -net nic,vlan=0,model=virtio -net user -drive file=ubuntu,if=virtio,cache=unsafe -smp 2 -m 1024
>>> boots normally at first, but then hangs as soon as Xorg gets started.`
>>> 
>> Which guest is is exactly and how reproducible is this?
> 
> Ubuntu 12.04.
> It's 100% reproducible or else it wouldn't have been so easily
> bisectable.
> 
>>> Perf top shows:
>>> 20.99%  [kernel]                                  [k] svm_vcpu_run
>>> 17.24%  [kernel]                                  [k] handle_mmio_page_fault_common
>>> 15.61%  [kernel]                                  [k] kvm_arch_vcpu_ioctl_run
>>> 12.49%  [kernel]                                  [k] fast_page_fault.part.78
>>> 
>>> I'm running:
>>> QEMU emulator version 1.4.2 
>>> on an AMD PhenomII X4 CPU.
>>> 
>> What is the output of "cat /proc/cpuinfo"?
> 
> 
> processor	: 0
> vendor_id	: AuthenticAMD
> cpu family	: 16
> model		: 4
> model name	: AMD Phenom(tm) II X4 955 Processor
> stepping	: 2
> microcode	: 0x10000db
> cpu MHz		: 800.000
> cache size	: 512 KB
> physical id	: 0
> siblings	: 4
> core id		: 0
> cpu cores	: 4
> apicid		: 0
> initial apicid	: 0
> fpu		: yes
> fpu_exception	: yes
> cpuid level	: 5
> wp		: yes
> flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm 3dnowext 3dnow constant_tsc rep_good nopl nonstop_tsc extd_apicid pni monitor cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt hw_pstate npt lbrv svm_lock nrip_save
> bogomips	: 6424.73
> TLB size	: 1024 4K pages
> clflush size	: 64
> cache_alignment	: 64
> address sizes	: 48 bits physical, 48 bits virtual
> power management: ts ttp tm stc 100mhzsteps hwpstate
> ...
> *4
> 
> -- 
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/