linux-kernel - Re: [PATCH 02/10] Add a generic associative array implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130717220732.302.qmail@science.horizon.com>
Date:	17 Jul 2013 18:07:32 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	dhowells@...hat.com
Cc:	joe@...ches.com, linux@...izon.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] Add a generic associative array implementation.

I have to say, the entire boolean type seems strange.  I haven't looked at
all the users, but wouldn't it be better to provide some simple helpers
to allow call sites to set and test lsbits, and document the array as
requiring 2-byte alignment of pointers?

Factoring it into two features like this would eliminate a significant
source of API cruft for callers that don't use the feature, without
cluttering callers that do too much.

And callers could take advantage of known alignment to use more lsbits
if they wanted to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/