linux-kernel - Re: [PATCH 0/3] tracing: more list_empty(perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374116446.6458.203.camel@gandalf.local.home>
Date:	Wed, 17 Jul 2013 23:00:46 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Oleg Nesterov <oleg@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] tracing: more list_empty(perf_events) checks

Peter,

These have been discussed, and they mostly live in the tracing
directory, but are perf related. Can you give me your Acked-by on them.

Thanks,

-- Steve


On Mon, 2013-06-17 at 19:01 +0200, Oleg Nesterov wrote:
> Hello.
> 
> Steven, we already discussed this a bit some time ago...
> 
> DECLARE_EVENT_CLASS()->perf_trace_##call() is not trivial because
> of __perf_task(), but perhaps we can change other
> perf_trace_buf_submit(task => NULL) callers.
> 
> 
> And can't we factor out WARN_ONCE(size > PERF_MAX_TRACE_SIZE) ?
> See 3/3. I won't argue if you dislike it.
> 
> Oleg.
> 
>  include/trace/ftrace.h          |    4 ----
>  kernel/trace/trace_event_perf.c |   10 ++++++++--
>  kernel/trace/trace_kprobe.c     |    6 ------
>  kernel/trace/trace_syscalls.c   |   24 ++++++++----------------
>  kernel/trace/trace_uprobe.c     |    2 --
>  5 files changed, 16 insertions(+), 30 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/