linux-kernel - Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130718235417.GA9538@roeck-us.net>
Date:	Thu, 18 Jul 2013 16:54:17 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, abbotti@....co.uk, oliver@...inagl.nl
Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute
 groups

On Sun, Jul 14, 2013 at 04:05:50PM -0700, Greg Kroah-Hartman wrote:
> Hi all,
> 
> Here is the third iteration of the patchset to add better attribute
> group support to the driver core and sysfs.
> 
> Others have now tested it, and we got 3 more patches fixing a warning
> that was showing up when binary attributes were in a group with no
> "normal" attributes, and some more helper macros were added and cleaned
> up.
> 
> I've booted this successfully against 3.11-rc1 with no problems (am
> sending these from that machine.)
> 
> Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later.  I
> considered it, but that would also mean a BUS_PATTR() and the like, which I
> guess works, but I hate even a _hint_ of "Hungarian" notation, which this
> implies.
> 
> Anyone else have a better name for this macro:
> 	#define DEVICE_PATTR(_name)	&dev_attr_##_name.attr
> that they can think of?  It will cut down on the typing done for
> attribute lists.
> 
> changes from v3:
> 	- tested by Guenter
> 	- patches from Oliver added
> 	- refreshed on 3.11-rc1 (minor fuzz)
> 	- Ian glanced at them.
> 
> changes from v2:
> 	- actually boots
> 	- 7th patch added properly
> 	- added BUS_ATTR, CLASS_ATTR, and DRIVER_ATTR RW and RO macros
> 	  to help with converting code to use attributes properly.
> 
Hi Greg,

thanks a lot for this series of patches, and for pushing it upstream.

Do you by any chance have a repository for the cleanup patches depending on this
series ? It looks like a good area to get involved with when I am tired/annoyed
by my other work, but I would not want to duplicate your work.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/