linux-kernel - Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E3C756.1080807@mev.co.uk>
Date:	Mon, 15 Jul 2013 10:56:38 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Ian Abbott <ian.abbott@....co.uk>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"oliver@...inagl.nl" <oliver@...inagl.nl>,
	"linux@...ck-us.net" <linux@...ck-us.net>
Subject: Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute
 groups

On 2013-07-15 10:41, Ian Abbott wrote:
> On 2013-07-15 00:05, Greg Kroah-Hartman wrote:
>> Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later.  I
>> considered it, but that would also mean a BUS_PATTR() and the like, which I
>> guess works, but I hate even a _hint_ of "Hungarian" notation, which this
>> implies.
>>
>> Anyone else have a better name for this macro:
>> 	#define DEVICE_PATTR(_name)	&dev_attr_##_name.attr
>> that they can think of?  It will cut down on the typing done for
>> attribute lists.
>
> DEVICE_ATTR_P or DEV_ATTR_P to save typing.  Or would that be confused
> with the P convention[1]?  If so, DEVICE_ATTR_PTR or DEV_ATTR_PTR could
> be used.
>
> [1] see Jargon File.

Then again, those follow the naming of DEVICE_ATTR_RO and DEVICE_ATTR_RW 
too closely.  Time for someone else to do a bit of bike-shedding.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/