linux-kernel - Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jul 2013 10:20:24 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq_ack callback
 implementation

Hi Axel,

Sorry for the late testing,

On Sat, Jul 06, 2013 at 10:35:29PM +0800, Axel Lin wrote:
> According to the datasheet[1], the Interrupt IRQ Pending Registers are
> read-only. The implementation of sun4i_irq_ack() looks wrong because it writes
> to these read-only registers.
> 
> This patch removes the wrong irq_ack callback implementation and all the code
> writing to these read-only registers in sun4i_of_init().
> 
> [1] http://dl.linux-sunxi.org/A10/A10%20User%20Manual%20-%20v1.20%20%282012-04-09%2c%20DECRYPTED%29.pdf
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> Hi Maxime,
>   I don't have this hardware, I'd appreciate if you can test this patch.
>   If this patch works, I think we can just drop the patch I sent yesterday.
>   ( It's "irqchip: sun4i: Staticize sun4i_irq_ack()"
>     https://lkml.org/lkml/2013/7/5/43 )
> 
> Thanks,
> Axel

Since your previous patch was merged, it generates a merge conflict when
applied on top of 3.11.

I guess you can rebase it on top of 3.11, and then you can add my 
Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)