linux-kernel - Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130711161353.GV11243@lukather>
Date:	Thu, 11 Jul 2013 18:13:53 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT] irqchip: sun4i: Remove wrong irq_ack callback
 implementation

Hi Axel,

On Sat, Jul 06, 2013 at 10:35:29PM +0800, Axel Lin wrote:
> According to the datasheet[1], the Interrupt IRQ Pending Registers are
> read-only. The implementation of sun4i_irq_ack() looks wrong because it writes
> to these read-only registers.

Right, but the datasheet also says that these registers are "clear"
register, which might indicate that it's actually R/W.

I actually used one of the code dump from Allwinner for this driver, so
I'm not exactly sure about wether irq_ack is needed or not.

I'll test this and let you know.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)