linux-kernel - Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51E94B30.9070805@linutronix.de>
Date:	Fri, 19 Jul 2013 16:20:32 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	George Cherian <george.cherian@...com>, linux-usb@...r.kernel.org,
	balbi@...com, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, linux-omap@...r.kernel.org,
	kishon@...com
Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

On 07/19/2013 03:56 PM, Sergei Shtylyov wrote:
> On 19-07-2013 16:34, George Cherian wrote:
> 
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi
>> b/arch/arm/boot/dts/am33xx.dtsi
>> index 8e1248f..e3890c4 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -326,21 +326,59 @@
>>               status = "disabled";
>>           };
>>
>> -        usb@...00000 {
>> -            compatible = "ti,musb-am33xx";
>> -            reg = <0x47400000 0x1000    /* usbss */
>> -                   0x47401000 0x800        /* musb instance 0 */
>> -                   0x47401800 0x800>;    /* musb instance 1 */
>> -            interrupts = <17        /* usbss */
>> -                      18        /* musb instance 0 */
>> -                      19>;        /* musb instance 1 */
>> -            multipoint = <1>;
>> -            num-eps = <16>;
>> -            ram-bits = <12>;
>> -            port0-mode = <3>;
>> -            port1-mode = <3>;
>> -            power = <250>;
>> -            ti,hwmods = "usb_otg_hs";
>> +        phy1: am335x-usb0@...10620 {
> 
>    Shouldn't the PHYs be *under* the usb0/1 device nodes in the hierarchy?
> They're not on the same bus as the MUSB controllers for sure.

I redo the complete thing. I have now:

usb: usb@...00000 {
	compatible = "ti,am33xx-usb";
	
	usb0_phy: phy@...01300 {
		compatible = "ti,am335x-usb-phy";
	}
	usb0: usb@...01000 {
		musb0: usb@...01400 {
			compatible = "mg,musbmhdrc";
		}
	}
	usb1_phy: phy@...02300 {
		compatible = "ti,am335x-usb-phy";
	}
	usb1: usb@...02000 {
		musb1: usb@...02400 {
			compatible = "mg,musbmhdrc";
		}
	}
}

And you want usb0_phy to be child of usb0? In the TRM they are all in
the same block.

> 
> WBR, Sergei
> 

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/