linux-kernel - Re: /proc/timer_list and weird behavior with dropbear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jul 2013 15:37:07 -0500
From:	Nathan Zimmer <nzimmer@....com>
To:	Nathan Zimmer <nzimmer@....com>
Cc:	Holger Hans Peter Freyther <holger@...yther.de>,
	linux-kernel@...r.kernel.org
Subject: Re: /proc/timer_list and weird behavior with dropbear

On Fri, Jul 19, 2013 at 03:33:24PM -0500, Nathan Zimmer wrote:
> On Fri, Jul 19, 2013 at 07:03:54PM +0200, Holger Hans Peter Freyther wrote:
> > On Fri, Jul 19, 2013 at 10:45:15AM -0500, Nathan Zimmer wrote:
> > 
> > > I hadn't noticed anything.
> > > Let me try your program and see what I may have missed.
> > 
> > Hi,
> > 
> > I neither know the semantics of the timer_list nor how to use
> > seq_file correctly. What happens is that timer_list_next will only
> > be called once. This means that iter->cpu will never be increased.
> > 
> > This just moves to the next CPU when stop is called (e.g. nothing
> > was added once the print_tickdevice was printed). Do you think
> > this could be correct?
> > 
> > 
> > 
> > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
> > index 3bdf283..8d36a3d 100644
> > --- a/kernel/time/timer_list.c
> > +++ b/kernel/time/timer_list.c
> > @@ -327,8 +327,10 @@ static void *timer_list_next(struct seq_file *file, void *v, loff_t *offset)
> >  	return timer_list_start(file, offset);
> >  }
> >  
> > -static void timer_list_stop(struct seq_file *seq, void *v)
> > +static void timer_list_stop(struct seq_file *file, void *v)
> >  {
> > +	struct timer_list_iter *iter = file->private;
> > +	iter->cpu = cpumask_next(iter->cpu, cpu_online_mask);
> >  }
> >  
> >  static const struct seq_operations timer_list_sops = {
> 
> 
> I think this would be an acceptable fix.
> It work file locally.  Could you check it out to see if it behaves?
> 
> Nate

Forgot the patch last time.
Sorry


View attachment "tlfix.patch" of type "text/x-patch" (1042 bytes)