linux-kernel - Re: [PATCH -v2] RTC: Add an alarm disable quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Jul 2013 23:19:27 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	John Stultz <john.stultz@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jiri Kosina <jkosina@...e.cz>,
	Borislav Petkov <bp@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rabin Vincent <rabin.vincent@...ricsson.com>
Subject: Re: [PATCH -v2] RTC: Add an alarm disable quirk

On Mon, Jul 22, 2013 at 02:00:42PM -0700, John Stultz wrote:
> Also, just to clarify, on the affected machines, with this patch,
> wake-up alarm's will in effect be disabled, right?

See below.

> >@@ -385,6 +418,9 @@ static int cmos_alarm_irq_enable(struct device *dev, unsigned int enabled)
> >  	if (!is_valid_irq(cmos->irq))
> >  		return -EINVAL;
> >+	if (!disable_alarm)
> >+		return 0;
> >+
> 
> Did you want this in cmos_alarm_irq_enable? Or cmos_irq_disable?

You're right - the first version did call it only in rtc_alarm_disable()
so I should move it to cmos_alarm_disable(). Will fix.

Btw, I did some more runs on the weekend. It seems, the setting of the
alarm interrupt bit in RTC_CONTROL doesn't matter. I dumped its contents
on shutdown and I had cases where it was 0x22 (bit 5 set) and 0x2.

So my hunch currently is us *not* disabling the alarm, doesn't make it
reboot the box.

I know, unfortunately this is still a brown paper bag and I don't have a
real rootcause...

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/