linux-kernel - Re: [PATCH 7/7] usb: phy: msm: Lindent the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130724122253.GC17962@radagast>
Date:	Wed, 24 Jul 2013 15:22:53 +0300
From:	Felipe Balbi <balbi@...com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	<linux-arm-msm@...r.kernel.org>, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] usb: phy: msm: Lindent the code

On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@...sol.com>
> 
> Cc: Felipe Balbi <balbi@...com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> 
> Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>

I really don't like blind Lindent patches... sometimes it makes things
even worse.

> ---
>  drivers/usb/phy/phy-msm-usb.c |   99 ++++++++++++++++++++++-------------------
>  1 file changed, 52 insertions(+), 47 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> index 6d05085..111f454 100644
> --- a/drivers/usb/phy/phy-msm-usb.c
> +++ b/drivers/usb/phy/phy-msm-usb.c
> @@ -64,8 +64,8 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
>  
>  	if (init) {
>  		ret = regulator_set_voltage(motg->vddcx,
> -				USB_PHY_VDD_DIG_VOL_MIN,
> -				USB_PHY_VDD_DIG_VOL_MAX);
> +					    USB_PHY_VDD_DIG_VOL_MIN,
> +					    USB_PHY_VDD_DIG_VOL_MAX);

like here, what's the point ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)